[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…
Github user sedgewickmm18 commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84291047 --- Diff: flink-contrib/docker-flink/docker-compose.sh --- @@ -0,0 +1,4 @@ +#!/bin/sh --- End diff -- that's fine --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…
Github user sedgewickmm18 commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84287069 --- Diff: flink-contrib/docker-flink/docker-compose.yml --- @@ -20,16 +20,20 @@ version: "2" services: jobmanager: image: flink +container_name: "jobmanager" +expose: + - "6123" ports: - "48081:8081" command: jobmanager -volumes: - - /opt/flink/conf taskmanager: image: flink +expose: + - "6121" + - "6122" --- End diff -- These lines expose taskmanager's RPC and data ports to make them accessible in the private subnet, please see https://docs.docker.com/docker-cloud/apps/ports/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…
Github user sedgewickmm18 commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84286390 --- Diff: flink-contrib/docker-flink/docker-entrypoint.sh --- @@ -20,11 +20,19 @@ if [ "$1" = "jobmanager" ]; then echo "Starting Job Manager" -sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address: `hostname -f`/g" $FLINK_HOME/conf/flink-conf.yaml +#sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address: `hostname -f`/g" $FLINK_HOME/conf/flink-conf.yaml + +# make use of container linking and exploit the jobmanager entry in /etc/hosts +sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address: jobmanager/g" $FLINK_HOME/conf/flink-conf.yaml + sed -i -e "s/taskmanager.numberOfTaskSlots: 1/taskmanager.numberOfTaskSlots: `grep -c ^processor /proc/cpuinfo`/g" $FLINK_HOME/conf/flink-conf.yaml --- End diff -- agree - makes much more sense that way - otherwise it's always one slot by default. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…
GitHub user sedgewickmm18 opened a pull request: https://github.com/apache/flink/pull/2667 README.md -Description of the bluemix specif⦠Hi, as per discussion with @mxm I'm proposing to include the following change that makes use of container linking (exposing a container specific hostname in /etc/hosts) so that taskmanagers can find the jobmanager) instead of shared volumes and handles fully qualified image names (including URL of the private registry + namespace). Best Regards, Markus List of changed files: build.sh -modify permissions to make script executable by default docker-compose-bluemix.yml -allow to specify image names with path to private BM registry docker-compose.sh -find out path to docker registry, extend build time to 120 secs, then call docker-compose docker-compose.yml -make use of container linking instead of shared volumes docker-entrypoint.sh -use 'jobmanager' entry in /etc/hosts arising from container linking so that taskmanager can register itself with jobmanager You can merge this pull request into a Git repository by running: $ git pull https://github.com/sedgewickmm18/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2667.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2667 commit 735ed871b528664afaac2ee46e8727b873b1ee97 Author: Markus Müller <markus_muel...@de.ibm.com> Date: 2016-10-20T08:08:34Z README.md -Description of the bluemix specific steps build.sh -modify permissions to make script executable by default docker-compose-bluemix.yml -allow to specify image names with path to private BM registry docker-compose.sh -find out path to docker registry, extend build time to 120 secs, then call docker-compose docker-compose.yml -make use of container linking instead of shared volumes docker-entrypoint.sh -use 'jobmanager' entry in /etc/hosts arising from container linking so that taskmanager can register itself with jobmanager --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
