[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-30 Thread GitBox 


1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1367867001

   Thanks @Myasuka and @yuchen-ecnu 's review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-23 Thread GitBox 


1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1363871116

   Thanks for your feedback, I recorded a demo here, it explains the problem 
with the current master branch and why these two changes should be made. 
   
   Please correct me if I'm wrong, thanks~
   
   
   
https://user-images.githubusercontent.com/38427477/209327755-06f2807b-8c0b-41e2-9ea4-9fc4994c9f26.mp4
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-21 Thread GitBox 


1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1362490165

   > I think even before this PR, the sort order is also the desc by default. 
@yuchen-ecnu could you also take a look at this PR?
   
   Thanks for your feedback, the `sortByBusyRatio` is `a - b`, so it's 
ascending order by default, and I have tested it's really ascending order. 
Please @yuchen-ecnu  help double check, thanks~
   
   ```
 sortByBusyRatio(a: JobBackpressureSubtask, b: JobBackpressureSubtask): 
number {
   return a.busyRatio - b.busyRatio;
 }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-21 Thread GitBox 


1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1361116851

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-20 Thread GitBox 


1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1360942141

   Hi @Myasuka , please help take a look in your free time, thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-20 Thread GitBox 


1996fanrui commented on PR #21540:
URL: https://github.com/apache/flink/pull/21540#issuecomment-1360874693

   After this PR: 
   
   1. The SortOrder of BusyRatio will be the desc by default.
   
   https://user-images.githubusercontent.com/38427477/208828005-d902a419-a197-4e55-be00-0b086cf89436.png;>
   
   2. It will sort by subtask when the user chooses not to sort.
   
   https://user-images.githubusercontent.com/38427477/208828189-3702ece1-a77e-43b8-b08f-0974ec4097b7.png;>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org