[GitHub] [flink] Aitozi commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…

2023-04-02 Thread via GitHub 


Aitozi commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1155295984


##
flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java:
##
@@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {
 + " |-- f0: BIGINT NOT NULL\n"
 + " |-- f1: STRING NOT NULL\n"
 + " |-- f2: DOUBLE NOT NULL\n"
-+ " |-- CONSTRAINT pk PRIMARY KEY (f0, f2)\n");
++ " |-- CONSTRAINT `pk` PRIMARY KEY (`f0`, 
`f2`) NOT ENFORCED\n");

Review Comment:
   Why this changed ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] Aitozi commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…

2023-03-29 Thread via GitHub 


Aitozi commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1152652365


##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/constraints/UniqueConstraint.java:
##
@@ -1,111 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.table.api.constraints;
-
-import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.table.catalog.ResolvedSchema;
-
-import java.util.List;
-import java.util.Objects;
-
-import static org.apache.flink.util.Preconditions.checkNotNull;
-
-/**
- * A unique key constraint. It can be declared also as a PRIMARY KEY.
- *
- * @see ConstraintType
- * @deprecated See {@link ResolvedSchema} and {@link
- * org.apache.flink.table.catalog.UniqueConstraint}.
- */
-@Deprecated
-@PublicEvolving

Review Comment:
   I'm afraid we can't directly remove this `@PublicEvolving`  API. CC 
@luoyuxia 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org