[GitHub] [flink] Cyberness commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer
Cyberness commented on PR #20257: URL: https://github.com/apache/flink/pull/20257#issuecomment-1379570234 Does it still make sense to work on merging this change considering [FLINK-30557](https://github.com/apache/flink/pull/21600)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] Cyberness commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer
Cyberness commented on PR #20257: URL: https://github.com/apache/flink/pull/20257#issuecomment-1275379856 > The code changes look good. Recognise that we specify a KryoSerializer instead of making the SequenceNumber a POJO to maintain backwards compatibility. Given that we are changing the state serializer, could we do a sanity test to check the following? > > * we can disableGenericTypes (as reported [here](https://issues.apache.org/jira/browse/FLINK-24549)) > * a snapshot created from old consumer is valid for a new consumer Yes, I can work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
