[GitHub] [flink] JavaPentesters commented on pull request #14675: [FLINK-18383][docs]translate "JDBC SQL Connector" documentation into …

2021-01-19 Thread GitBox 


JavaPentesters commented on pull request #14675:
URL: https://github.com/apache/flink/pull/14675#issuecomment-763295166


   @leonardBang Thanks for your review! All the mentioned comments have been 
solved! And, The documentation can be translated to HTML!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] JavaPentesters commented on pull request #14675: [FLINK-18383][docs]translate "JDBC SQL Connector" documentation into …

2021-01-18 Thread GitBox 


JavaPentesters commented on pull request #14675:
URL: https://github.com/apache/flink/pull/14675#issuecomment-762620839


   > > @leonardBang Thanks for all your great suggestion! It's my first time to 
receive PR review.So, what should I do next? How to append commit?
   > 
   > You can append a commit to address the comments, you can directly push 
code to your remote branch(git push origin JavaPentesters) after appended 
commit in your local branch (`JavaPentesters:master`) , the PR will update 
automatically.
   
   Thanks for your directions! I have appended a commit to fix this 
issues.Looking forward to seeing you to help me to review this again!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] JavaPentesters commented on pull request #14675: [FLINK-18383][docs]translate "JDBC SQL Connector" documentation into …

2021-01-18 Thread GitBox 


JavaPentesters commented on pull request #14675:
URL: https://github.com/apache/flink/pull/14675#issuecomment-762574753


   @leonardBang Thanks for all your great suggestion! It's my first time to 
receive PR review.So, what should I do next? How to append commit? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org