[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-17 Thread GitBox


JerryYue-M commented on PR #21197:
URL: https://github.com/apache/flink/pull/21197#issuecomment-1318528698

   @zhuzhurk  I checked with https://issues.apache.org/jira/browse/FLINK-21000
   some question:
   1. this issue is just for the source coordinator, it's not a common way for 
every implement of operatorcoordinator
   2. it takes a long time to merge into the Flink community


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-17 Thread GitBox


JerryYue-M commented on PR #21197:
URL: https://github.com/apache/flink/pull/21197#issuecomment-1318514095

   @zhuzhurk  thanks for reply  I will take a talk with @arunans23 later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-16 Thread GitBox


JerryYue-M commented on PR #21197:
URL: https://github.com/apache/flink/pull/21197#issuecomment-1318220393

   @zhuzhurk  
   your comments had resolved and no checkstyle and compile problems, can you 
take a look at those new changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-16 Thread GitBox


JerryYue-M commented on PR #21197:
URL: https://github.com/apache/flink/pull/21197#issuecomment-1318219982

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-14 Thread GitBox


JerryYue-M commented on PR #21197:
URL: https://github.com/apache/flink/pull/21197#issuecomment-1314699793

   @zhuzhurk 
   all your comments had resolved and no checkstyle and compile problems, can 
you take a look at those new changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-14 Thread GitBox


JerryYue-M commented on PR #21197:
URL: https://github.com/apache/flink/pull/21197#issuecomment-1314697589

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-14 Thread GitBox


JerryYue-M commented on PR #21197:
URL: https://github.com/apache/flink/pull/21197#issuecomment-1313446096

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-13 Thread GitBox


JerryYue-M commented on PR #21197:
URL: https://github.com/apache/flink/pull/21197#issuecomment-1313211460

   @flinkbot  run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-07 Thread GitBox


JerryYue-M commented on PR #21197:
URL: https://github.com/apache/flink/pull/21197#issuecomment-1305428610

   @zhuzhurk can you review it again, all the discussion had resolved
   thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-03 Thread GitBox


JerryYue-M commented on PR #21197:
URL: https://github.com/apache/flink/pull/21197#issuecomment-1302998406

   @zhuzhurk  all the questions you mentioned had resolved, add  ut to check 
all the operator coordinators had registered metrics after scheduling, please 
review it again
   thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org