[GitHub] [flink] Jiabao-Sun commented on pull request #23218: [FLINK-32854][flink-runtime][JUnit5 Migration] The state package of flink-runtime module

2023-09-11 Thread via GitHub


Jiabao-Sun commented on PR #23218:
URL: https://github.com/apache/flink/pull/23218#issuecomment-1713643735

   Test count verified:
   
   master
  passed: 1291, ignored: 98, total: 1389
   updated:
  passed: 1291, ignored: 98, total: 1383, disabled: 7
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] Jiabao-Sun commented on pull request #23218: [FLINK-32854][flink-runtime][JUnit5 Migration] The state package of flink-runtime module

2023-09-10 Thread via GitHub


Jiabao-Sun commented on PR #23218:
URL: https://github.com/apache/flink/pull/23218#issuecomment-1712816006

   Thanks @1996fanrui for the continuous help.
   Please help with it again when you have time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] Jiabao-Sun commented on pull request #23218: [FLINK-32854][flink-runtime][JUnit5 Migration] The state package of flink-runtime module

2023-08-28 Thread via GitHub


Jiabao-Sun commented on PR #23218:
URL: https://github.com/apache/flink/pull/23218#issuecomment-1696047403

   Thanks @1996fanrui for the hard review and sorry for the oversight.
   Please help review it again when you have time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] Jiabao-Sun commented on pull request #23218: [FLINK-32854][flink-runtime][JUnit5 Migration] The state package of flink-runtime module

2023-08-27 Thread via GitHub


Jiabao-Sun commented on PR #23218:
URL: https://github.com/apache/flink/pull/23218#issuecomment-1694972823

   Hi @1996fanrui.
   Could you help review this PR when you have time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] Jiabao-Sun commented on pull request #23218: [FLINK-32854][flink-runtime][JUnit5 Migration] The state package of flink-runtime module

2023-08-18 Thread via GitHub


Jiabao-Sun commented on PR #23218:
URL: https://github.com/apache/flink/pull/23218#issuecomment-1684311049

   Thanks @ferenc-csaky for the detailed review and helpful suggestions.
   Most of the comments are fixed.
   Please help review it again when you have time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org