[GitHub] [flink] JingsongLi commented on a change in pull request #10001: [FLINK-14535][table-planner-blink] Fix distinct key type for DecimalT…
JingsongLi commented on a change in pull request #10001: [FLINK-14535][table-planner-blink] Fix distinct key type for DecimalT… URL: https://github.com/apache/flink/pull/10001#discussion_r339387049 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/AggregateUtil.scala ## @@ -505,7 +503,7 @@ object AggregateUtil extends Enumeration { case VARCHAR | CHAR => fromLegacyInfoToDataType(BinaryStringTypeInfo.INSTANCE) Review comment: Can you change this to `DataTypes.VARCHAR(precision).bridgeTo(BinaryString.class)`, I think that is the right way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10001: [FLINK-14535][table-planner-blink] Fix distinct key type for DecimalT…
JingsongLi commented on a change in pull request #10001: [FLINK-14535][table-planner-blink] Fix distinct key type for DecimalT… URL: https://github.com/apache/flink/pull/10001#discussion_r339387049 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/AggregateUtil.scala ## @@ -505,7 +503,7 @@ object AggregateUtil extends Enumeration { case VARCHAR | CHAR => fromLegacyInfoToDataType(BinaryStringTypeInfo.INSTANCE) Review comment: Can you change this to `DataTypes.VARCHAR(precision).bridgeTo(BinaryString.class)` and `DataTypes.CHAR(precision).bridgeTo(BinaryString.class)`, I think that is the right way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services