[GitHub] [flink] JingsongLi commented on pull request #14229: [FLINK-20292][doc] Improve the document about table formats overlap in user fat jar

2020-12-03 Thread GitBox 


JingsongLi commented on pull request #14229:
URL: https://github.com/apache/flink/pull/14229#issuecomment-737737701


   Looks good to me. Thanks @leonardBang and @gaoyunhaii , merging...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] JingsongLi commented on pull request #14229: [FLINK-20292][doc] Improve the document about table formats overlap in user fat jar

2020-12-02 Thread GitBox 


JingsongLi commented on pull request #14229:
URL: https://github.com/apache/flink/pull/14229#issuecomment-737623316


   > Links to this section from the specific format pages (like avro) under the 
Dependencies section so that users jump to specific pages could also see the 
warnings.
   
   I think this is a little redundant, we don't need add same words in every 
formats, what do you think? @gaoyunhaii @leonardBang 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org