[GitHub] [flink] JingsongLi commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

2022-01-24 Thread GitBox


JingsongLi commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020901998


   Hi @zjureel I replied you in JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] JingsongLi commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

2022-01-25 Thread GitBox


JingsongLi commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020901998


   Hi @zjureel I replied you in JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] JingsongLi commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

2022-01-25 Thread GitBox


JingsongLi commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1021804321


   > Thanks @JingsongLi , I think I miss the operations in `MemoryManager` :( 
And another issue is in 
`BinaryHashTableTest.testBinaryHashBucketAreaNotEnoughMem`, there's no 
`table.free` after `table.close`, I think it should be and it causes memory 
leaks in my cache memory manager. What do you think?
   
   I don't know, it seems that `area.freeMemory()` will release memory?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org