[GitHub] [flink] JunRuiLee commented on pull request #22555: [FLINK-31706] [runtime] The default source parallelism should be the same as ex…
JunRuiLee commented on PR #22555: URL: https://github.com/apache/flink/pull/22555#issuecomment-1543623829 @clownxc Thanks for updating. I'm sorry that I overlooked that this pr will lead to a change in the default behavior of the configuration `ADAPTIVE_AUTO_PARALLELISM_DEFAULT_SOURCE_PARALLELISM`, and this kind of change needs to initiate a discussion in the dev mail list. @wanglijie95 Could you help to have a look? WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] JunRuiLee commented on pull request #22555: [FLINK-31706] [runtime] The default source parallelism should be the same as ex…
JunRuiLee commented on PR #22555: URL: https://github.com/apache/flink/pull/22555#issuecomment-1542095484 @clownxc Thanks for creating this pr! I'm curious why you don't fallback the value of globalDefaultSourceParallelism to parallelism.default if necessary outside the constructor of DefaultVertexParallelismAndInputInfosDecider? This change will be much cleaner. In addition, we do not require that parallelism.default must be a positive number. On the contrary, before version 1.17, users need to configure parallelism.default = -1 to enable concurrency derivation. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
