[GitHub] [flink] KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch
KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480705151 I don't think it's an optimization. I would say it's intuition every reader will have in the first place. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch
KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480699105 I think the problem is the methods you proposed: `isLeftBoundRowInWindow` and `isRightBoundRowInWindow`. In `RowSlidingOverFrame`, there is no need to iterate rows preceding and following, and check whether it belongs to current frame one by one. As I said before, you can immediately determine the left and right boundary with `currentIndex - precedingCount, currentIndex + followingCount` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch
KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480690209 Isn't `(currentIndex - precedingCount, currentIndex + followingCount) enough for RowSlidingOverFrame? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch
KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480670657 Why `RowSlidingOverFrame` needs a comparator class? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
