[GitHub] [flink] KurtYoung commented on pull request #12069: [FLINK-14807][streaming] Add specialized collecting sink function

2020-05-15 Thread GitBox 


KurtYoung commented on pull request #12069:
URL: https://github.com/apache/flink/pull/12069#issuecomment-629054948


   We need a dedicated test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] KurtYoung commented on pull request #12069: [FLINK-14807][streaming] Add specialized collecting sink function

2020-05-14 Thread GitBox 


KurtYoung commented on pull request #12069:
URL: https://github.com/apache/flink/pull/12069#issuecomment-629035731


   Still need a multi thread tests for `CollectSinkFunction` to test the case 
when buffer is full and block the main thread.
   And also need add some tests for `CollectSinkOperatorCoordinator`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org