[GitHub] [flink] Myasuka commented on a change in pull request #12153: [FLINK-16966][metrics][infuxdb] Convert InfluxDB reporter to plugin

2020-05-14 Thread GitBox 


Myasuka commented on a change in pull request #12153:
URL: https://github.com/apache/flink/pull/12153#discussion_r425552234



##
File path: 
flink-metrics/flink-metrics-influxdb/src/main/java/org/apache/flink/metrics/influxdb/InfluxdbReporterFactory.java
##
@@ -0,0 +1,14 @@
+package org.apache.flink.metrics.influxdb;
+
+import org.apache.flink.metrics.reporter.MetricReporter;
+import org.apache.flink.metrics.reporter.MetricReporterFactory;
+
+import java.util.Properties;
+
+public class InfluxdbReporterFactory implements MetricReporterFactory {

Review comment:
   This class miss a javadoc and should not pass during checkstyle.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] Myasuka commented on a change in pull request #12153: [FLINK-16966][metrics][infuxdb] Convert InfluxDB reporter to plugin

2020-05-15 Thread GitBox 


Myasuka commented on a change in pull request #12153:
URL: https://github.com/apache/flink/pull/12153#discussion_r426116917



##
File path: 
flink-metrics/flink-metrics-influxdb/src/main/java/org/apache/flink/metrics/influxdb/InfluxdbReporterFactory.java
##
@@ -0,0 +1,14 @@
+package org.apache.flink.metrics.influxdb;
+
+import org.apache.flink.metrics.reporter.MetricReporter;
+import org.apache.flink.metrics.reporter.MetricReporterFactory;
+
+import java.util.Properties;
+
+public class InfluxdbReporterFactory implements MetricReporterFactory {

Review comment:
   I'm afraid you did not understand what I mean. This class 
`InfluxdbReporterFactory` missed a javadoc, please check the CI failure or 
build your code local.
   Moreover, I still suggest you to fill the content of description of this PR.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org