[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary

2021-04-12 Thread GitBox


Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-817769158


   @StephanEwen , sorry for missing this reply during my spring festival 
holidays. Flink-1.13 did not bump the RocksDB version finally and it seems 
there is no test failure reported during this time.
   Maybe we could mark FLINK-17511 to be resolved in Flink-1.14.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary

2021-02-10 Thread GitBox


Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-777255056


   @StephanEwen , yes I agree with your concern. Current memory control 
mechanism of RocksDB cannot handle any malloced memory not inserted into block 
cache or write buffer, those just uncompressed data block could have OOM risk. 
   Actually we are trying several optimizations to improve customer experience:
   
   1. Partitioned index option https://github.com/apache/flink/pull/14341 to 
help avoid performance problem during memory control.
   1. Try to bump RocksDB after 6.10+ to have more restrict block cache size 
limit.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary

2021-02-10 Thread GitBox


Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-777247888


   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary

2021-02-05 Thread GitBox


Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-773884428


   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary

2021-02-05 Thread GitBox


Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-773884428


   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary

2021-01-26 Thread GitBox


Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-767982133


   @StephanEwen could you please take a look at this PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary

2021-01-26 Thread GitBox


Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-767972038


   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary

2021-01-25 Thread GitBox


Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766651035


   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #14744: [FLINK-17511][tests] Rerun RocksDB memory control tests if necessary

2021-01-25 Thread GitBox


Myasuka commented on pull request #14744:
URL: https://github.com/apache/flink/pull/14744#issuecomment-766651035


   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org