[GitHub] [flink] SteNicholas removed a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-12-02 Thread GitBox 


SteNicholas removed a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-737624582


   > example
   
   @kl0u , IMO, I really want to follow the remaining comments from 
@tillrohrmann , and continue to update the commit according to Till's above 
comments. It's better for me to merge this pull request in the end.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] SteNicholas removed a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-24 Thread GitBox 


SteNicholas removed a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-733034701


   > 2\. ExecutionGraphBuilder
   
   @tillrohrmann , thanks for your detailed review. My answer for above 
question you mentioned is as follows:
   1.`ProgramInvocationException` isn't the part of the public API of a 
`JobClient`. Even if it is, it is wrapped into `CompletableFuture`.
   2.Why the `JobExecutionException` is  removed from the runtime components 
(specifically the `ExecutionGraphBuilder`)? What are the adverse effects of 
this？



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] SteNicholas removed a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-20 Thread GitBox 


SteNicholas removed a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-731046963


   @tillrohrmann , could you please review this pull request for the 
application status of `JobExecutionException? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] SteNicholas removed a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-16 Thread GitBox 


SteNicholas removed a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-727142827


   > I am having a look right now @SteNicholas 
   
   @kl0u Any other comments by you?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] SteNicholas removed a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-11 Thread GitBox 


SteNicholas removed a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725301089


   @kl0u , could you please help to review this commit if you are available?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org