[GitHub] [flink] StephanEwen commented on issue #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible
StephanEwen commented on issue #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible URL: https://github.com/apache/flink/pull/8877#issuecomment-507571804 Couldn't we move these classes into the metrics modules? Both the test base and the `DescriptiveStatisticsHistogram`? It seems just wrong to couple the metrics to the runtime modules for these dependencies. Sorry for being nit-picking here, but we need to push for more clean and lean dependency structure. Too many times that we had to work around issues with out dependency jungle... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible
StephanEwen commented on issue #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible URL: https://github.com/apache/flink/pull/8877#issuecomment-506281800 Looks good in general. What is a bit strange is that the dropwizard metrics now have dependencies on flink-runtime. Is that because `DescriptiveStatisticsHistogram` is in the wrong place (`flink-runtime`)? Should that implementation be in the metrics projects instead? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
