[GitHub] [flink] StephanEwen commented on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request
StephanEwen commented on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request URL: https://github.com/apache/flink/pull/9132#issuecomment-515511582 From my side, +1 to commit this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request
StephanEwen commented on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request URL: https://github.com/apache/flink/pull/9132#issuecomment-515129785 @zhijiangW @NicoK @azagrebin @zentol I addressed the review comments, put some minor changes on top to make consumption notifications idempotent. That allows also for some more slight simplification/cleanup. Will open a PR with this as soon as I the tests passed once on Travis. https://github.com/StephanEwen/flink/commits/network This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request
StephanEwen commented on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request URL: https://github.com/apache/flink/pull/9132#issuecomment-514705841 I am wondering why we distinguish cases where we release with/without consumption notification. To me, all release should include a consumption notification - similar to what @azagrebin raised in the JIRA discussion. The reason is that `notifySubpartitionConsumed()` has a semantic of "a consumption attempt finished". And all release cases also indicate that. I understand that this is not exactly the behavior we had before, but I would argue that the behavior before was actually incorrect and we should fix this now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
