[GitHub] [flink] Tartarus0zm commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox


Tartarus0zm commented on pull request #17672:
URL: https://github.com/apache/flink/pull/17672#issuecomment-962970666


   @JingsongLi  hello, please take a look, if you have time, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Tartarus0zm commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-07 Thread GitBox


Tartarus0zm commented on pull request #17672:
URL: https://github.com/apache/flink/pull/17672#issuecomment-962761027


   @tsreaper  thanks for your review. I has fix the comments, please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Tartarus0zm commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-05 Thread GitBox


Tartarus0zm commented on pull request #17672:
URL: https://github.com/apache/flink/pull/17672#issuecomment-961817197


   @tsreaper  thank you for your reply. I have added test cases, please take a 
look, if you have time, thanks
   cc @KurtYoung 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Tartarus0zm commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-05 Thread GitBox


Tartarus0zm commented on pull request #17672:
URL: https://github.com/apache/flink/pull/17672#issuecomment-961817197


   @tsreaper  thank you for your reply. I have added test cases, please take a 
look, if you have time, thanks
   cc @KurtYoung 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Tartarus0zm commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-05 Thread GitBox


Tartarus0zm commented on pull request #17672:
URL: https://github.com/apache/flink/pull/17672#issuecomment-961817197


   @tsreaper  thank you for your reply. I have added test cases, please take a 
look, if you have time, thanks
   cc @KurtYoung 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Tartarus0zm commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-04 Thread GitBox


Tartarus0zm commented on pull request #17672:
URL: https://github.com/apache/flink/pull/17672#issuecomment-960556387


   @tsreaper  please take a look, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Tartarus0zm commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-04 Thread GitBox


Tartarus0zm commented on pull request #17672:
URL: https://github.com/apache/flink/pull/17672#issuecomment-960546440


   @JingsongLi  @wuchong  If you have time, please take a look, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org