[GitHub] [flink] V1ncentzzZ commented on pull request #13472: [FLINK-19291][Formats] Fix `SchemaParseException` when use `AvroSchemaConverter` converts flink logical type
V1ncentzzZ commented on pull request #13472: URL: https://github.com/apache/flink/pull/13472#issuecomment-698705423 Hi @danny0405 @wuchong , would you help review this PR? Thank you very much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] V1ncentzzZ commented on pull request #13472: [FLINK-19291][Formats] Fix `SchemaParseException` when use `AvroSchemaConverter` converts flink logical type
V1ncentzzZ commented on pull request #13472: URL: https://github.com/apache/flink/pull/13472#issuecomment-698705423 Hi @danny0405 @wuchong , would you help review this PR? Thank you very much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] V1ncentzzZ commented on pull request #13472: [FLINK-19291][Formats] Fix `SchemaParseException` when use `AvroSchemaConverter` converts flink logical type
V1ncentzzZ commented on pull request #13472: URL: https://github.com/apache/flink/pull/13472#issuecomment-706127900 Hi @wuchong , I updated issue [FLINK-19291](https://issues.apache.org/jira/browse/FLINK-19291), you can using the example posted in JIRA issue FLINK-19291 to reproduce the exception. The root cause of this problem that there are multiple row type fields and the field names in each row type are different. I will update the issue description later. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] V1ncentzzZ commented on pull request #13472: [FLINK-19291][Formats] Fix `SchemaParseException` when use `AvroSchemaConverter` converts flink logical type
V1ncentzzZ commented on pull request #13472: URL: https://github.com/apache/flink/pull/13472#issuecomment-706127900 Hi @wuchong , I updated issue [FLINK-19291](https://issues.apache.org/jira/browse/FLINK-19291), you can using the example posted in JIRA issue FLINK-19291 to reproduce the exception. The root cause of this problem that there are multiple row type fields and the field names in each row type are different. I will update the issue description later. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] V1ncentzzZ commented on pull request #13472: [FLINK-19291][Formats] Fix `SchemaParseException` when use `AvroSchemaConverter` converts flink logical type
V1ncentzzZ commented on pull request #13472: URL: https://github.com/apache/flink/pull/13472#issuecomment-706482787 Hi @wuchong , Thanks for your guidance. I hava been submitted my code, due to the default row name is based on the current millis. it will affect the execution of the test case `org.apache.flink.formats.avro.AvroFormatFactoryTest#testSeDeSchema`. I think it is enough to use a special string as the default row name. Do you hava any suggestions about the default row name? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] V1ncentzzZ commented on pull request #13472: [FLINK-19291][Formats] Fix `SchemaParseException` when use `AvroSchemaConverter` converts flink logical type
V1ncentzzZ commented on pull request #13472: URL: https://github.com/apache/flink/pull/13472#issuecomment-706497537 Hi @wuchong , As you said, I used "record" as top name and optimization test case. Thank you very much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
