[GitHub] [flink] XComp commented on a change in pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints

[GitBox]

XComp commented on a change in pull request #14584:
URL: https://github.com/apache/flink/pull/14584#discussion_r556320209



##
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##
@@ -1018,10 +1018,10 @@ private void setCoLocation() {
 "Cannot use a co-location constraint without a 
slot sharing group");
 }
 
-Tuple2 constraint =
+Tuple2 constraint =
 coLocationGroups.computeIfAbsent(
 coLocationGroupKey,
-k -> new Tuple2<>(sharingGroup, new 
CoLocationGroup()));
+k -> new Tuple2<>(sharingGroup, new 
CoLocationGroupImpl()));

Review comment:
   See my answer above.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] XComp commented on a change in pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints

[GitBox]

XComp commented on a change in pull request #14584:
URL: https://github.com/apache/flink/pull/14584#discussion_r556320074



##
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java
##
@@ -425,12 +426,12 @@ public void setStrictlyCoLocatedWith(JobVertex 
strictlyCoLocatedWith) {
 "Strict co-location requires that both vertices are in the 
same slot sharing group.");
 }
 
-CoLocationGroup thisGroup = this.coLocationGroup;
-CoLocationGroup otherGroup = strictlyCoLocatedWith.coLocationGroup;
+CoLocationGroupImpl thisGroup = this.coLocationGroup;
+CoLocationGroupImpl otherGroup = strictlyCoLocatedWith.coLocationGroup;

Review comment:
   The idea was to have a readonly interface as the colocation groups do 
not need to be changed after initialization.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org