[GitHub] [flink] XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the bug of timestampadd handles time

2019-12-08 Thread GitBox
XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the 
bug of timestampadd handles time
URL: https://github.com/apache/flink/pull/8746#issuecomment-563072805
 
 
   hi @walterddr Thank you very much for this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the bug of timestampadd handles time

2019-12-03 Thread GitBox
XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the 
bug of timestampadd handles time
URL: https://github.com/apache/flink/pull/8746#issuecomment-561513087
 
 
   hi @walterddr Thanks again, This PR I addressed it.
   Best,
   forward


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the bug of timestampadd handles time

2019-12-01 Thread GitBox
XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the 
bug of timestampadd handles time
URL: https://github.com/apache/flink/pull/8746#issuecomment-560207520
 
 
   @wuchong any additional comments


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the bug of timestampadd handles time

2019-11-27 Thread GitBox
XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the 
bug of timestampadd handles time
URL: https://github.com/apache/flink/pull/8746#issuecomment-559288102
 
 
   hi @walterddr This PR I addressed it.
   Thanks
   forward


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the bug of timestampadd handles time

2019-11-27 Thread GitBox
XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the 
bug of timestampadd handles time
URL: https://github.com/apache/flink/pull/8746#issuecomment-559124700
 
 
   hi  @walterddr This PR I addressed it.
   Thanks
   forward


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the bug of timestampadd handles time

2019-11-25 Thread GitBox
XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the 
bug of timestampadd handles time
URL: https://github.com/apache/flink/pull/8746#issuecomment-558121572
 
 
   hi @wuchong @walterddr Can you take the time to review this PR? 
   Thanks
   forward


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the bug of timestampadd handles time

2019-06-18 Thread GitBox
XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the 
bug of timestampadd handles time
URL: https://github.com/apache/flink/pull/8746#issuecomment-503066318
 
 
   hi @walterddr Thank you for review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the bug of timestampadd handles time

2019-06-16 Thread GitBox
XuQianJin-Stars commented on issue #8746: [hotfix][FLINK-11120][table]fix the 
bug of timestampadd handles time
URL: https://github.com/apache/flink/pull/8746#issuecomment-502505999
 
 
   hi @walterddr I haven't seen your question yet, I think it's still separate 
in another PR to locate the problem you are talking about. Because it is 
possible to synchronize and adjust the syntax and semantics of calcite. What do 
you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services