[GitHub] [flink] aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema URL: https://github.com/apache/flink/pull/8371#issuecomment-570554230 I merged, thanks a lot for your work and patience! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema URL: https://github.com/apache/flink/pull/8371#issuecomment-570173617 I pushed a branch that squashes commits and adds some simplification. I'm now working on extending `test_confluent_schema_registry.sh` to also test writing to a schema registry because that part of the code is completely untested as of now. I'm also wondering about the new `subject` parameter of `ConfluentSchemaRegistryCoder`, we use this when writing the schema but never use it when reading to schema. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema URL: https://github.com/apache/flink/pull/8371#issuecomment-566041705 @Wosin could you please rebase on master and squash it into sensible commits, as you would like to have them merged in the end. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema URL: https://github.com/apache/flink/pull/8371#issuecomment-559420365 By the way, I'm on the ASF slack workspace: https://s.apache.org/slack-invite. You can ping me there so that we can resolve reviews quicker. Sometimes it takes quite some time with the back-and-forth on github. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema URL: https://github.com/apache/flink/pull/8371#issuecomment-559020628 @Wosin Is there a reason `RegistryAvroSerializationSchema.serialize()` and `ConfluentRegistryAvroSerializationSchema.serialize()` are different? Shouldn't both register the scheam and serialize the schema id? Also, in `RegistryAvroSerializationSchema` we don't use the `schemaCoder` that is set in `checkAvroInitialized()`. I can fix that while merging because I also fixed the checkstyle problems in my local checkout of the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema URL: https://github.com/apache/flink/pull/8371#issuecomment-555384761 There are build failures because of checkstyle: https://travis-ci.com/flink-ci/flink/builds/137108234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema URL: https://github.com/apache/flink/pull/8371#issuecomment-542689920 @soumyasmruti So you're saying the PR in the current state does not work? @Wosin Do you have a comment on that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema URL: https://github.com/apache/flink/pull/8371#issuecomment-506282454 @Wosin could you please rebase and squash the various commits into some commits that make sense, i.e. separate pre-requisites like version upgrade into a separate commit and then have the actual implementation commit? I'd like to review this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
