[GitHub] [flink] aljoscha commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
aljoscha commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-720353902 No worries. 😃 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
aljoscha commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-719463468 @zjffdu Should we still try and get this in for Flink 1.12? Sorry for the very long delay on this one! 😱 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
aljoscha commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-620429912 @zentol How do you mean? When building with Scala 2.11 `flink-scala-shell` is excluded, so the tests for the shell are not run on a Scala 2.12 build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
aljoscha commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619943491 The assertions in `ScalaShellITCase` fail because the invoked programs produce null pointer exceptions. I didn't look further, so I don't know why the exceptions are thrown. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
aljoscha commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619869705 The tests don't pass, I reverted the change on master. Sorry about this, I was too eager in merging. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
aljoscha commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619830497 I'm running the test locally now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12
aljoscha commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619824128 Ah sorry @tillrohrmann! While you were writing your message I was merging the PR. I was assuming that azure and travis run the Scala 2.12 profiles. What should we do? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
