[GitHub] [flink] azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools
azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-544589920 Thanks @carp84 , merging it when CI is green This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools
azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-544511037 Thanks for the review @carp84 I addressed the comments and introduced `MemoryReservationException` for `MemoryManager.reserveMemory` instead of `MemoryAllocationException`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools
azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-542100750 Thanks for the reviews @xintongsong @KarmaGYZ I removed the pre-allocation left-overs, I guess got lost during rebases, thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools
azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-541687094 Thanks for the review @xintongsong I addressed the comments This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools
azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-533599524 Thanks for the review @KarmaGYZ I have updated the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin commented on issue #9693: Flink 13984
azagrebin commented on issue #9693: Flink 13984 URL: https://github.com/apache/flink/pull/9693#issuecomment-531803716 cc @xintongsong This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
