[GitHub] [flink] clownxc commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
clownxc commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1155962586
##
flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java:
##
@@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {
+ " |-- f0: BIGINT NOT NULL\n"
+ " |-- f1: STRING NOT NULL\n"
+ " |-- f2: DOUBLE NOT NULL\n"
-+ " |-- CONSTRAINT pk PRIMARY KEY (f0, f2)\n");
++ " |-- CONSTRAINT `pk` PRIMARY KEY (`f0`,
`f2`) NOT ENFORCED\n");
Review Comment:
this is the deprecated UniqueConstraint
```java
public final String asSummaryString() {
final String typeString;
switch (getType()) {
case PRIMARY_KEY:
typeString = "PRIMARY KEY";
break;
case UNIQUE_KEY:
typeString = "UNIQUE";
break;
default:
throw new IllegalStateException("Unknown key type: " +
getType());
}
return String.format(
"CONSTRAINT %s %s (%s)", getName(), typeString,
String.join(", ", columns));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] clownxc commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
clownxc commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1155958077
##
flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java:
##
@@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {
+ " |-- f0: BIGINT NOT NULL\n"
+ " |-- f1: STRING NOT NULL\n"
+ " |-- f2: DOUBLE NOT NULL\n"
-+ " |-- CONSTRAINT pk PRIMARY KEY (f0, f2)\n");
++ " |-- CONSTRAINT `pk` PRIMARY KEY (`f0`,
`f2`) NOT ENFORCED\n");
Review Comment:
there are some minor differences between the new and old APIs
```java
public final String asSummaryString() {
return String.format(
"CONSTRAINT %s %s (%s)%s",
EncodingUtils.escapeIdentifier(getName()),
getTypeString(),
columns.stream()
.map(EncodingUtils::escapeIdentifier)
.collect(Collectors.joining(", ")),
isEnforced() ? "" : " NOT ENFORCED");
}
```
The method `escapeIdentifier` of the new api adds a symbol `` to each field
```java
public static String escapeIdentifier(String s) {
return "`" + escapeBackticks(s) + "`";
}
```
@Aitozi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] clownxc commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
clownxc commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1155957023
##
flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java:
##
@@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {
+ " |-- f0: BIGINT NOT NULL\n"
+ " |-- f1: STRING NOT NULL\n"
+ " |-- f2: DOUBLE NOT NULL\n"
-+ " |-- CONSTRAINT pk PRIMARY KEY (f0, f2)\n");
++ " |-- CONSTRAINT `pk` PRIMARY KEY (`f0`,
`f2`) NOT ENFORCED\n");
Review Comment:
there are some minor differences between the new and old APIs
```java
public final String asSummaryString() {
return String.format(
"CONSTRAINT %s %s (%s)%s",
EncodingUtils.escapeIdentifier(getName()),
getTypeString(),
columns.stream()
.map(EncodingUtils::escapeIdentifier)
.collect(Collectors.joining(", ")),
isEnforced() ? "" : " NOT ENFORCED");
}
```
The method `escapeIdentifier` of the new api adds a symbol `` to each field
```java
public static String escapeIdentifier(String s) {
return "`" + escapeBackticks(s) + "`";
}
```
@Aitozi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] clownxc commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
clownxc commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1155957023
##
flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java:
##
@@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {
+ " |-- f0: BIGINT NOT NULL\n"
+ " |-- f1: STRING NOT NULL\n"
+ " |-- f2: DOUBLE NOT NULL\n"
-+ " |-- CONSTRAINT pk PRIMARY KEY (f0, f2)\n");
++ " |-- CONSTRAINT `pk` PRIMARY KEY (`f0`,
`f2`) NOT ENFORCED\n");
Review Comment:
there are some minor differences between the new and old APIs
```java
public final String asSummaryString() {
return String.format(
"CONSTRAINT %s %s (%s)%s",
EncodingUtils.escapeIdentifier(getName()),
getTypeString(),
columns.stream()
.map(EncodingUtils::escapeIdentifier)
.collect(Collectors.joining(", ")),
isEnforced() ? "" : " NOT ENFORCED");
}
```
The method `escapeIdentifier` of the new api adds a symbol `` to each field
```java
public static String escapeIdentifier(String s) {
return "`" + escapeBackticks(s) + "`";
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] clownxc commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
clownxc commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1153161683
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/constraints/UniqueConstraint.java:
##
@@ -1,111 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.table.api.constraints;
-
-import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.table.catalog.ResolvedSchema;
-
-import java.util.List;
-import java.util.Objects;
-
-import static org.apache.flink.util.Preconditions.checkNotNull;
-
-/**
- * A unique key constraint. It can be declared also as a PRIMARY KEY.
- *
- * @see ConstraintType
- * @deprecated See {@link ResolvedSchema} and {@link
- * org.apache.flink.table.catalog.UniqueConstraint}.
- */
-@Deprecated
-@PublicEvolving
Review Comment:
> +1. Share same concern. We must be cautious about dropping
`@PublicEvolving` api.
Thank you so much for review. I will rollback '@ PublicEvolving' api Delete
operation @luoyuxia @Aitozi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
