[GitHub] [flink] curcur commented on pull request #16653: [FLINK-23558][streaming] Ignoring RejectedExecutionException during s…

2021-08-05 Thread GitBox 


curcur commented on pull request #16653:
URL: https://github.com/apache/flink/pull/16653#issuecomment-892546067






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] curcur commented on pull request #16653: [FLINK-23558][streaming] Ignoring RejectedExecutionException during s…

2021-08-04 Thread GitBox 


curcur commented on pull request #16653:
URL: https://github.com/apache/flink/pull/16653#issuecomment-893129290


   Thanks for fixing this @akalash , merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] curcur commented on pull request #16653: [FLINK-23558][streaming] Ignoring RejectedExecutionException during s…

2021-08-04 Thread GitBox 


curcur commented on pull request #16653:
URL: https://github.com/apache/flink/pull/16653#issuecomment-892546067


   Thanks @akalash for fixing this. Approved with a bit of comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] curcur commented on pull request #16653: [FLINK-23558][streaming] Ignoring RejectedExecutionException during s…

2021-08-03 Thread GitBox 


curcur commented on pull request #16653:
URL: https://github.com/apache/flink/pull/16653#issuecomment-892379997


   @akalash 
   
   I've looked through the code again, I think we should probably also keep 
   ```  
   timersFinishedFuture.get();
   systemTimersFinishedFuture.get();
   ```
   
   in the task thread for the safety purposes. 
   
   I mean we move this two lines of code into the actionExecutor and keep the 
same copy in its origin place.
   
   I think for normal task, actionExecutor is the same task thread, but there 
is also some cases (like sources) that they maybe  different 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] curcur commented on pull request #16653: [FLINK-23558][streaming] Ignoring RejectedExecutionException during s…

2021-08-03 Thread GitBox 


curcur commented on pull request #16653:
URL: https://github.com/apache/flink/pull/16653#issuecomment-891622506


   I have a bit concern of this:
   
   this change swallows all "RejectedExecutionException" no matter it is 
because of task finish or not.
   
   I think the right fix is not to submit mailbox execution after the task 
finishes?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org