[GitHub] [flink] curcur commented on pull request #16685: [FLINK-23279][tests] Randomly use Changelog Backend in tests
curcur commented on pull request #16685: URL: https://github.com/apache/flink/pull/16685#issuecomment-894094497 Please make sure addresing confilicts before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] curcur commented on pull request #16685: [FLINK-23279][tests] Randomly use Changelog Backend in tests
curcur commented on pull request #16685: URL: https://github.com/apache/flink/pull/16685#issuecomment-894093949 I do not further concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] curcur commented on pull request #16685: [FLINK-23279][tests] Randomly use Changelog Backend in tests
curcur commented on pull request #16685: URL: https://github.com/apache/flink/pull/16685#issuecomment-892362947 LGTM overall, thanks @rkhachatryan for enabling the tests! Please take a look at my inline comments. Also, before accepting it, 1. We should run the test with `flag = on` to make sure all related tests pass. I think that's what've already done, but I want to double check and make sure of that. 2. We should also change the configuration setting description in `CheckpointingOptions` `public static final ConfigOption STATE_CHANGE_LOG_STORAGE ` to include "filesystem". Right now it "includes memory only" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
