[GitHub] [flink] danny0405 commented on pull request #13291: [FLINK-18988][table] Continuous query with LATERAL and LIMIT produces…

2020-11-20 Thread GitBox 


danny0405 commented on pull request #13291:
URL: https://github.com/apache/flink/pull/13291#issuecomment-731049628


   Thanks @godfreyhe , i have addressed the review comments, can you take a 
look again ~ Thanks so much in advance ~



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] danny0405 commented on pull request #13291: [FLINK-18988][table] Continuous query with LATERAL and LIMIT produces…

2020-11-17 Thread GitBox 


danny0405 commented on pull request #13291:
URL: https://github.com/apache/flink/pull/13291#issuecomment-728895936


   > Thanks for the fix @danny0405, I left some comments.
   > btw, I find the blink batch planner does not support the given query, and 
I get some errors in sql-client, like 
"org.apache.flink.table.api.TableException: unexpected correlate variable $cor1 
in the plan"
   
   Yes, because out batch rank only supports rank type as `RANK`, see 
`BatchExecRankRule` match condition, while here we use the `ROW_NUMBER`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] danny0405 commented on pull request #13291: [FLINK-18988][table] Continuous query with LATERAL and LIMIT produces…

2020-09-16 Thread GitBox 


danny0405 commented on pull request #13291:
URL: https://github.com/apache/flink/pull/13291#issuecomment-693799225


   > I'm trying to base an example on this PR. But the results differ between 
batch and streaming mode. It seems that the batch mode now outputs the global 
maximum.
   
   The patch is only for streaming purpose, let me check if batch mode is 
supported.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org