[GitHub] [flink] dawidwys commented on pull request #13521: [FLINK-19472] Implement a one input sorting DataInput

2020-10-05 Thread GitBox 


dawidwys commented on pull request #13521:
URL: https://github.com/apache/flink/pull/13521#issuecomment-703670703


   I hope I addressed your comments @aljoscha @pnowojski Could you take another 
look?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #13521: [FLINK-19472] Implement a one input sorting DataInput

2020-10-05 Thread GitBox 


dawidwys commented on pull request #13521:
URL: https://github.com/apache/flink/pull/13521#issuecomment-703634517


   I run the benchmarks and the only significant difference (regression) is in 
the `unalignedCheckpoint`. There is a clear explanation though as my branch did 
not include the changes that resulted in performance improvement from the 1st 
Oct (FLINK-16972 & FLINK-19400). I can also rerun with rebased changes if you 
will.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org