[GitHub] [flink] dianfu commented on a change in pull request #11068: [FLINK-15964] [cep] fix getting event of previous stage in notFollowedBy may throw exception bug

2020-02-15 Thread GitBox 
dianfu commented on a change in pull request #11068: [FLINK-15964] [cep] fix 
getting event of previous stage in notFollowedBy may throw exception bug
URL: https://github.com/apache/flink/pull/11068#discussion_r379826440
 
 

 ##
 File path: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
 ##
 @@ -2844,4 +2845,35 @@ public void testSharedBufferClearing() throws Exception 
{
Mockito.verify(accessor, 
Mockito.times(1)).advanceTime(2);
}
}
+
+   /**
+* Test that can access the value of the previous stage directly in 
notFollowedBy.
+*
+* @see https://issues.apache.org/jira/browse/FLINK-15964";>FLINK-15964
+* @throws Exception
+*/
+   @Test
+   public void testAccessPreviousStageInNotFollowedBy() throws Exception {
 
 Review comment:
   What about move this test case to NotPatternITCase which is dedicated for 
not pattern?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11068: [FLINK-15964] [cep] fix getting event of previous stage in notFollowedBy may throw exception bug

2020-02-15 Thread GitBox 
dianfu commented on a change in pull request #11068: [FLINK-15964] [cep] fix 
getting event of previous stage in notFollowedBy may throw exception bug
URL: https://github.com/apache/flink/pull/11068#discussion_r379826374
 
 

 ##
 File path: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
 ##
 @@ -2844,4 +2845,35 @@ public void testSharedBufferClearing() throws Exception 
{
Mockito.verify(accessor, 
Mockito.times(1)).advanceTime(2);
}
}
+
+   /**
+* Test that can access the value of the previous stage directly in 
notFollowedBy.
+*
 
 Review comment:
   The Java doc could be removed as I think the method name already describes 
clearly what it does. What do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services