[GitHub] [flink] dianfu commented on a change in pull request #14282: [FLINK-20442][python][legal] Updated flink-python NOTICE
dianfu commented on a change in pull request #14282: URL: https://github.com/apache/flink/pull/14282#discussion_r533801315 ## File path: flink-python/src/main/resources/META-INF/NOTICE ## @@ -67,11 +68,20 @@ The bundled Apache Beam dependencies bundle the following dependencies under the - io.netty:netty-tcnative-boringssl-static:2.0.26.Final - io.opencensus:opencensus-api:0.24.0 - io.opencensus:opencensus-contrib-grpc-metrics:0.24.0 -- net.bytebuddy:1.10.8 +- io.perfmark:perfmark-api:0.19.0 +- net.jpountz.lz4:lz4:1.3.0 The bundled Apache Beam dependencies bundle the following dependencies under the BSD license. See bundled license files for details - com.google.auth:google-auth-library-credentials:0.18.0 +- com.google.protobuf.nano:protobuf-javanano:3.0.0-alpha-5 - com.google.protobuf:protobuf-java:3.11.0 - com.google.protobuf:protobuf-java-util:3.11.0 +- com.jcraft:jzlib:1.1.3 + +The bundled Apache Beam dependencies bundle the following dependencies under the Bouncy Castle license. +See bundled license files for details + +- org.bouncycastle:bcpkix-jdk15on:1.54 Review comment: Yes, you are right. Most dependencies are pulled in because of beam grpc vendor which is defined in https://github.com/apache/beam/blob/release-2.23.0/buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy. As jetty and jboss are not needed and so I excluded them from the fat jar. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #14282: [FLINK-20442][python][legal] Updated flink-python NOTICE
dianfu commented on a change in pull request #14282: URL: https://github.com/apache/flink/pull/14282#discussion_r533801315 ## File path: flink-python/src/main/resources/META-INF/NOTICE ## @@ -67,11 +68,20 @@ The bundled Apache Beam dependencies bundle the following dependencies under the - io.netty:netty-tcnative-boringssl-static:2.0.26.Final - io.opencensus:opencensus-api:0.24.0 - io.opencensus:opencensus-contrib-grpc-metrics:0.24.0 -- net.bytebuddy:1.10.8 +- io.perfmark:perfmark-api:0.19.0 +- net.jpountz.lz4:lz4:1.3.0 The bundled Apache Beam dependencies bundle the following dependencies under the BSD license. See bundled license files for details - com.google.auth:google-auth-library-credentials:0.18.0 +- com.google.protobuf.nano:protobuf-javanano:3.0.0-alpha-5 - com.google.protobuf:protobuf-java:3.11.0 - com.google.protobuf:protobuf-java-util:3.11.0 +- com.jcraft:jzlib:1.1.3 + +The bundled Apache Beam dependencies bundle the following dependencies under the Bouncy Castle license. +See bundled license files for details + +- org.bouncycastle:bcpkix-jdk15on:1.54 Review comment: Yes, you are right. jetty and jboss are not needed and so excluded from the fat jar. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #14282: [FLINK-20442][python][legal] Updated flink-python NOTICE
dianfu commented on a change in pull request #14282: URL: https://github.com/apache/flink/pull/14282#discussion_r533544292 ## File path: flink-python/lib/LICENSE.py4j ## @@ -1,26 +0,0 @@ -Copyright (c) 2009-2018, Barthelemy Dagenais and individual contributors. All Review comment: They also appear in the directory https://github.com/apache/flink/tree/master/licenses and so the binary distribution should include them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #14282: [FLINK-20442][python][legal] Updated flink-python NOTICE
dianfu commented on a change in pull request #14282: URL: https://github.com/apache/flink/pull/14282#discussion_r533538517 ## File path: flink-python/lib/LICENSE.py4j ## @@ -1,26 +0,0 @@ -Copyright (c) 2009-2018, Barthelemy Dagenais and individual contributors. All Review comment: As pointed by Chesney, these licenses also appear in the directory of licenses/ and so we could remove them. What do you think? ## File path: flink-python/lib/LICENSE.cloudpickle ## @@ -1,32 +0,0 @@ -This module was extracted from the `cloud` package, developed by Review comment: ditto This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
