[GitHub] [flink] elkhand commented on pull request #23406: [FLINK-32884] [flink-clients] PyFlink remote execution should support URLs with paths and https scheme
elkhand commented on PR #23406: URL: https://github.com/apache/flink/pull/23406#issuecomment-1724945763 > Not sure I understand the feature from user perspective樂 The new URL is clear, the existing booleans for SSL are clear. What I would like to ask is what happens when I set `SecurityOptions.SSL_REST_ENABLED = false` and `URL=https://...` and the other way around? I mean which part of the code is configured by the new path var and which part by the old boolean? I'm asking it because we're setting `SecurityOptions.SSL_REST_ENABLED` dynamically... Updated code. Now we set SSL_REST_ENABLED if URL starts with https only: https://github.com/apache/flink/pull/23406/files#diff-2ebb5c60764d835a040c0e36aff8f42ae9a0239cb1186afd3d220b6e18d3dcb7R69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] elkhand commented on pull request #23406: [FLINK-32884] [flink-clients] PyFlink remote execution should support URLs with paths and https scheme
elkhand commented on PR #23406: URL: https://github.com/apache/flink/pull/23406#issuecomment-1722651735 > Tests are failing due to the new config options: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=53293=logs=fc5181b0-e452-5c8f-68de-1097947f6483=995c650b-6573-581c-9ce6-7ad4cc038461 > > You need to follow the steps listed in the error message to generate the documentation for the config options. (line 32660) Thank you, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
