[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-05-26 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-634158071


   Suggestions accepted @leonardBang 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-05-22 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-632754987


   @wuchong or @leonardBang ? Do you have time to review this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-05-21 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-632378430


   Rebased again..



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-05-20 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-631442974


   Updated PR to resolve conflicts



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-05-19 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-630892217


   Addressed comments. Now the PR should be ok



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-05-16 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-629603964


   > Hi @fpompermaier , yes, your understanding in your email is right, and 
#12090 LGTM. Can you rebase the PR and revert the decimal part?
   
   I'll do it after the merge of the other PR otherwise I'm always on solving 
conflicts



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-05-04 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-623697631


   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-05-04 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-623697329


   @flinkbot run travis
   
   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-05-04 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-623310522


   @flinkbot run travis
   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-04-29 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-621281455


   @bowenli86 I'll add them within tomorrow hopefully



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-04-24 Thread GitBox


fpompermaier commented on pull request #11900:
URL: https://github.com/apache/flink/pull/11900#issuecomment-619212627


   @flinkbot run travis
   @flinkbot run azure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org