[GitHub] [flink] fsk119 commented on a diff in pull request #21322: [FLINK-30025][table] the max column width should be resizable while printing the query result to the client console.
fsk119 commented on code in PR #21322:
URL: https://github.com/apache/flink/pull/21322#discussion_r1027681988
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##
@@ -926,7 +926,7 @@ private TableResultInternal
executeQueryOperation(QueryOperation operation) {
DataTypeUtils.expandCompositeTypeToSchema(
sinkOperation.getConsumedDataType()),
resultProvider.getRowDataStringConverter(),
-PrintStyle.DEFAULT_MAX_COLUMN_WIDTH,
Review Comment:
If we introduce this option, I think `PrintStyle.DEFAULT_MAX_COLUMN_WIDTH`
is useless. When building `TableauStyle`, we should read from TableConfig to
get the value for max column width.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] fsk119 commented on a diff in pull request #21322: [FLINK-30025][table] the max column width should be resizable while printing the query result to the client console.
fsk119 commented on code in PR #21322:
URL: https://github.com/apache/flink/pull/21322#discussion_r1027679751
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##
@@ -102,6 +102,16 @@ private TableConfigOptions() {}
+ "the session time zone is used during
conversion. The input of option is either a full name "
+ "such as \"America/Los_Angeles\", or a
custom timezone id such as \"GMT-08:00\".");
+@Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+public static final ConfigOption PRINT_MAX_COLUMN_WIDTH =
Review Comment:
I mean user can use
```
set table.print.max-column-width=100;
```
or
```
set sql-client.display.max-column-width=100
``
to adjust the column width. I am not sure the current modification can
achieve the goal.
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##
@@ -102,6 +102,16 @@ private TableConfigOptions() {}
+ "the session time zone is used during
conversion. The input of option is either a full name "
+ "such as \"America/Los_Angeles\", or a
custom timezone id such as \"GMT-08:00\".");
+@Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+public static final ConfigOption PRINT_MAX_COLUMN_WIDTH =
Review Comment:
I mean user can use
```
set table.print.max-column-width=100;
```
or
```
set sql-client.display.max-column-width=100
```
to adjust the column width. I am not sure the current modification can
achieve the goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] fsk119 commented on a diff in pull request #21322: [FLINK-30025][table] the max column width should be resizable while printing the query result to the client console.
fsk119 commented on code in PR #21322:
URL: https://github.com/apache/flink/pull/21322#discussion_r1027549706
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##
@@ -102,6 +102,16 @@ private TableConfigOptions() {}
+ "the session time zone is used during
conversion. The input of option is either a full name "
+ "such as \"America/Los_Angeles\", or a
custom timezone id such as \"GMT-08:00\".");
+@Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+public static final ConfigOption PRINT_MAX_COLUMN_WIDTH =
Review Comment:
Currently SQL Client also has the option
`sql-client.display.max-column-width`. When users set the option
`sql-client.display.max-column-width` or `sql-client.display.max-column-width`
in the client, can we adjust the column width?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] fsk119 commented on a diff in pull request #21322: [FLINK-30025][table] the max column width should be resizable while printing the query result to the client console.
fsk119 commented on code in PR #21322:
URL: https://github.com/apache/flink/pull/21322#discussion_r1027555804
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##
@@ -926,7 +926,7 @@ private TableResultInternal
executeQueryOperation(QueryOperation operation) {
DataTypeUtils.expandCompositeTypeToSchema(
sinkOperation.getConsumedDataType()),
resultProvider.getRowDataStringConverter(),
-PrintStyle.DEFAULT_MAX_COLUMN_WIDTH,
Review Comment:
I think we should remove the PrintStyle.DEFAULT_MAX_COLUMN_WIDTH now.
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##
@@ -102,6 +102,16 @@ private TableConfigOptions() {}
+ "the session time zone is used during
conversion. The input of option is either a full name "
+ "such as \"America/Los_Angeles\", or a
custom timezone id such as \"GMT-08:00\".");
+@Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+public static final ConfigOption PRINT_MAX_COLUMN_WIDTH =
Review Comment:
Currently SQL Client also has the option
`sql-client.display.max-column-width`. When users set the option
`sql-client.display.max-column-width` in the client, can we adjust the column
width?
##
docs/layouts/shortcodes/generated/table_config_configuration.html:
##
@@ -62,6 +62,12 @@
Enum
Strategy how to restore catalog objects such as tables,
functions, or data types using a given plan and performing catalog lookups if
necessary. It influences the need for catalog metadata to bepresent and enables
partial enrichment of plan information.Possible
values:"ALL": Reads all metadata about catalog tables, functions, or
data types that has been persisted in the plan. The strategy performs a catalog
lookup by identifier to fill in missing information or enrich mutable options.
If the original object is not available in the catalog anymore, pipelines can
still be restored if all information necessary is contained in the
plan."ALL_ENFORCED": Requires that all metadata about catalog tables,
functions, or data types has been persisted in the plan. The strategy will
neither perform a catalog lookup by identifier nor enrich mutable options with
catalog information. A restore will fail if not all information necessary is
contained in the
plan."IDENTIFIER": Uses only the identifier of catalog tables,
functions, or data types and always performs a catalog lookup. A restore will
fail if the original object is not available in the catalog anymore. Additional
metadata that might be contained in the plan will be ignored.
+
+table.print.max-column-width Streaming
Review Comment:
I think the name should be discussed. I lean to
`table.display.max-column-width`. cc @wuchong @godfreyhe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
