[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1041232393 cc @gyfora @mbalassi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1041433531 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1042704830 @mbalassi started a build on my win box and gathering the logs. When it's done hopefully I can attach it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1042903703 I've made much more extensive tests to make it bulletproof. It has turned out that the first approach worked only under some circumstances. Namely if `flink-runtime-web` is compiled anytime after the checkout alone then the full build worked, BUT and here comes the nasty trick :) I've made a full clean checkout and there it was failing for whatever reason consistently. I've changed the approach and with the new code it works with clean checkout too. I've attached the maven output from my win box: [build.log](https://github.com/apache/flink/files/8088613/build.log) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1043018193 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1043030695 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1044277105 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1044817068 Oh gosh, tests are super flaky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1044819809 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1048677742 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1048747555 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
