[GitHub] [flink] haydenzhourepo commented on a change in pull request #14554: [FLINK-20798] add kubernates config in ha doc

2021-01-06 Thread GitBox 


haydenzhourepo commented on a change in pull request #14554:
URL: https://github.com/apache/flink/pull/14554#discussion_r553148565



##
File path: docs/deployment/ha/kubernetes_ha.md
##
@@ -52,6 +52,10 @@ In order to identify the Flink cluster, you have to specify 
a `kubernetes.cluste
 
   kubernetes.cluster-id: cluster1337
 
+- [kubernetes.namespace]({% link deployment/config.md %}#kubernetes-namespace) 
(required):
+The namespace that will be used for running the jobmanager and taskmanager 
pods.
+  kubernetes.namespace: cluster-namespace

Review comment:
   this is not the required configuration but is an important 
configuration, refer to the [FLINK-20798] problem, if the user deployed FLINK 
cluster not on the default namespace then the deploy will fail because of the 
wrong namespace specified. so the document should remind of the user this 
configuration. and I will remove the `required` tag then submit.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] haydenzhourepo commented on a change in pull request #14554: [FLINK-20798] add kubernates config in ha doc

2021-01-06 Thread GitBox 


haydenzhourepo commented on a change in pull request #14554:
URL: https://github.com/apache/flink/pull/14554#discussion_r553148565



##
File path: docs/deployment/ha/kubernetes_ha.md
##
@@ -52,6 +52,10 @@ In order to identify the Flink cluster, you have to specify 
a `kubernetes.cluste
 
   kubernetes.cluster-id: cluster1337
 
+- [kubernetes.namespace]({% link deployment/config.md %}#kubernetes-namespace) 
(required):
+The namespace that will be used for running the jobmanager and taskmanager 
pods.
+  kubernetes.namespace: cluster-namespace

Review comment:
   this is not the required configuration but is an important 
configuration, refer to the [FLINK-20798] problem, if the user deployed FLINK 
cluster not on the default namespace then the deploy will fail because of the 
wrong namespace specified. so the document should remind of the user this 
configuration. and I will remote the required tag then submit.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org