ifndef-SleePy commented on issue #8870: [FLINK-12974][checkstyle] Bump
checkstyle to 8.14
URL: https://github.com/apache/flink/pull/8870#issuecomment-506306235
@hmcl You mean downgrade to an earlier version? I don't think it's a good
choice to use an older version. Because I believe 8.12 was well tested for
Flink project by @zentol . The earlier version might not cover the feature of
8.12.
And the reason I propose to upgrade to 8.14 is that, the commit message of
checkstyle plugin shows that there is no breaking change between 8.12 and 8.14.
It mapped 8.11/8.12/8.13 to 8.14.
Actually I think it's better to upgrade to the newest stable version. Of
course it should be well tested for Flink project.
I think we should separate this into two steps, a quick fixing to 8.14 with
a quick testing, and a big upgrade with well testing. Because many people have
read the guide "Adopting a Code Style and Quality Guide" written by Stephan,
and some of them have taken a practice just like me. And they may be confused
on the setting of checkstyle plugin.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
