[GitHub] [flink] jackwener commented on a change in pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project

[GitBox]

jackwener commented on a change in pull request #17842:
URL: https://github.com/apache/flink/pull/17842#discussion_r756532516



##
File path: 
flink-java/src/test/java/org/apache/flink/api/java/utils/OptionsTest.java
##
@@ -54,16 +54,6 @@ public void testChoicesWithValidDefaultValue() {
 Assert.assertEquals(option.getDefaultValue(), "a");
 }
 
-@Test
-public void testChoicesWithInvalidDefautlValue() throws 
RequiredParametersException {

Review comment:
   fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] jackwener commented on a change in pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project

[GitBox]

jackwener commented on a change in pull request #17842:
URL: https://github.com/apache/flink/pull/17842#discussion_r756124578



##
File path: 
flink-java/src/test/java/org/apache/flink/api/java/utils/OptionsTest.java
##
@@ -54,16 +54,6 @@ public void testChoicesWithValidDefaultValue() {
 Assert.assertEquals(option.getDefaultValue(), "a");
 }
 
-@Test
-public void testChoicesWithInvalidDefautlValue() throws 
RequiredParametersException {

Review comment:
   Then change the name?  testChoicesWithInvalidDefaultValue**Second**().
   Or, merge them into one test?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] jackwener commented on a change in pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project

[GitBox]

jackwener commented on a change in pull request #17842:
URL: https://github.com/apache/flink/pull/17842#discussion_r755746986



##
File path: 
flink-java/src/test/java/org/apache/flink/api/java/utils/OptionsTest.java
##
@@ -54,16 +54,6 @@ public void testChoicesWithValidDefaultValue() {
 Assert.assertEquals(option.getDefaultValue(), "a");
 }
 
-@Test
-public void testChoicesWithInvalidDefautlValue() throws 
RequiredParametersException {

Review comment:
   It's redundant




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] jackwener commented on a change in pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project

[GitBox]

jackwener commented on a change in pull request #17842:
URL: https://github.com/apache/flink/pull/17842#discussion_r755746522



##
File path: 
flink-java/src/test/java/org/apache/flink/api/java/utils/OptionsTest.java
##
@@ -54,16 +54,6 @@ public void testChoicesWithValidDefaultValue() {
 Assert.assertEquals(option.getDefaultValue(), "a");
 }
 
-@Test

Review comment:
   It's redundant




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org