[GitHub] [flink] kl0u commented on issue #9228: [FLINK-13428][Connectors / FileSystem] allow part file names to be configurable
kl0u commented on issue #9228: [FLINK-13428][Connectors / FileSystem] allow part file names to be configurable URL: https://github.com/apache/flink/pull/9228#issuecomment-518982686 Done! Sorry for the delay @eskabetxe This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] kl0u commented on issue #9228: [FLINK-13428][Connectors / FileSystem] allow part file names to be configurable
kl0u commented on issue #9228: [FLINK-13428][Connectors / FileSystem] allow part file names to be configurable URL: https://github.com/apache/flink/pull/9228#issuecomment-518977800 No @eskabetxe , I can do that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] kl0u commented on issue #9228: [FLINK-13428][Connectors / FileSystem] allow part file names to be configurable
kl0u commented on issue #9228: [FLINK-13428][Connectors / FileSystem] allow part file names to be configurable URL: https://github.com/apache/flink/pull/9228#issuecomment-518188938 @eskabetxe I will merge this PR to the master branch though. This means that it will be part of the `release-1.10` and not the `release-1.9`, as the feature-freeze period for 1.9 has already started a couple of weeks ago. Thanks for the work! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] kl0u commented on issue #9228: [FLINK-13428][Connectors / FileSystem] allow part file names to be configurable
kl0u commented on issue #9228: [FLINK-13428][Connectors / FileSystem] allow part file names to be configurable URL: https://github.com/apache/flink/pull/9228#issuecomment-517595409 Hi @eskabetxe ! If you run `mvn verify` in `flink-streaming-java` module you will see that there are `checkstyle` violations that prevent the build from succeeding. Please fix that and in the meantime I will have a look at the rest of the changes. In addition, please integrate the changes in a new commit (do not squash them into the previous one) and do not force push, as this makes tracking the changes more difficult. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] kl0u commented on issue #9228: [FLINK-13428][Connectors / FileSystem] allow part file names to be configurable
kl0u commented on issue #9228: [FLINK-13428][Connectors / FileSystem] allow part file names to be configurable URL: https://github.com/apache/flink/pull/9228#issuecomment-516839961 @eskabetxe thanks for the work, I will have a look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
