[GitHub] [flink] klion26 commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-04-04 Thread GitBox
klion26 commented on issue #7987: [FLINK-11820][serialization] 
SimpleStringSchema handle message record which value is null
URL: https://github.com/apache/flink/pull/7987#issuecomment-480127016
 
 
   thanks for you contribution, LGTM now


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] klion26 commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-03-15 Thread GitBox
klion26 commented on issue #7987: [FLINK-11820][serialization] 
SimpleStringSchema handle message record which value is null
URL: https://github.com/apache/flink/pull/7987#issuecomment-473261160
 
 
   Nice catch, and thank you for your contribution @lamber-ken. we should avoid 
`git merge` in the git history and use `git rebase` instead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services