[GitHub] [flink] klion26 commented on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese

2020-11-10 Thread GitBox


klion26 commented on pull request #13750:
URL: https://github.com/apache/flink/pull/13750#issuecomment-724643200


   @RocMarshal thanks for the update, merging.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] klion26 commented on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese

2020-11-09 Thread GitBox


klion26 commented on pull request #13750:
URL: https://github.com/apache/flink/pull/13750#issuecomment-724001184


   @RocMarshal When I pull your branch locally, seems there are two other 
commits between 296c869ceac85 and 9793b9c23786a9, I'm not sure why could this 
happen, could you please double-check it on your side? 
   
   And very much appreciate it if you could squash the commit into a single 
one, I'm not very familiar with merge commit into master currently :)
   
   
   ```
   275378338d (HEAD -> RE_13750, R13750) Update 
docs/monitoring/checkpoint_monitoring.zh.md
   1ec411ddcf Update docs/monitoring/checkpoint_monitoring.zh.md
   9793b9c237 Update docs/monitoring/checkpoint_monitoring.zh.md
   726435e10d [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' 
page of 'Debugging & Monitoring' into Chinese
   3b9e20aafc [FLINK-17528][table] Remove ArrayData#get() API and use 
ElementGetter instead
   debbdc66a4 [FLINK-17528][table] Remove RowData#get() API and use FieldGetter 
instead
   296c869cea [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' 
page of 'Debugging & Monitoring' into Chinese
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] klion26 commented on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese

2020-11-08 Thread GitBox


klion26 commented on pull request #13750:
URL: https://github.com/apache/flink/pull/13750#issuecomment-723711963


   @dianfu thanks for the review, will merge this one soon.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org