[GitHub] [flink] lamber-ken commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-05-31 Thread GitBox
lamber-ken commented on issue #7987: [FLINK-11820][serialization] 
SimpleStringSchema handle message record which value is null
URL: https://github.com/apache/flink/pull/7987#issuecomment-497632006
 
 
   > @lamber-ken I think yes. You can try to recover the commits via: 
https://help.github.com/en/articles/checking-out-pull-requests-locally
   
   @GJL, I open a new PR, and update it as your comment, see #8583


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] lamber-ken commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-05-31 Thread GitBox
lamber-ken commented on issue #7987: [FLINK-11820][serialization] 
SimpleStringSchema handle message record which value is null
URL: https://github.com/apache/flink/pull/7987#issuecomment-497619024
 
 
   Hi @GJL, 
   
   Thanks for your review and your comment is great for me. But my branch has 
been deleted unexpectly, so I can't commit anything, need I open a new PR?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] lamber-ken commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-05-07 Thread GitBox
lamber-ken commented on issue #7987: [FLINK-11820][serialization] 
SimpleStringSchema handle message record which value is null
URL: https://github.com/apache/flink/pull/7987#issuecomment-490150049
 
 
   hi, @GJL @tillrohrmann, this pr fix NPE in some scenarioscan, can you take a 
look here? Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] lamber-ken commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-04-04 Thread GitBox
lamber-ken commented on issue #7987: [FLINK-11820][serialization] 
SimpleStringSchema handle message record which value is null
URL: https://github.com/apache/flink/pull/7987#issuecomment-479787896
 
 
   @klion26,cc


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] lamber-ken commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-03-17 Thread GitBox
lamber-ken commented on issue #7987: [FLINK-11820][serialization] 
SimpleStringSchema handle message record which value is null
URL: https://github.com/apache/flink/pull/7987#issuecomment-473745024
 
 
   @klion26, hi, I have changed it as you suggest, three steps:
   1) git revert
   2) git pull rebase
   3) git push


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] lamber-ken commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-03-15 Thread GitBox
lamber-ken commented on issue #7987: [FLINK-11820][serialization] 
SimpleStringSchema handle message record which value is null
URL: https://github.com/apache/flink/pull/7987#issuecomment-473268359
 
 
   @klion26, I see, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services