[GitHub] [flink] liming30 commented on pull request #20405: [FLINK-28010][state] Use deleteRange to optimize the clear method of RocksDBMapState.

[GitBox]

liming30 commented on PR #20405:
URL: https://github.com/apache/flink/pull/20405#issuecomment-1211512386

   @fredia If we want to test the performance of RocksDB after `deleteRange`, 
the conclusion should have been given in the last part of this 
[blog](https://rocksdb.org/blog/2018/11/21/delete-range.html).
   
   Do you mean that the performance of `Point Lookups` and `Range Scans` should 
be verified again in Flink's benchmark?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] liming30 commented on pull request #20405: [FLINK-28010][state] Use deleteRange to optimize the clear method of RocksDBMapState.

[GitBox]

liming30 commented on PR #20405:
URL: https://github.com/apache/flink/pull/20405#issuecomment-1202096355

   > @liming30 Thanks for your PR. Would you like to share some improvements if 
this PR merged via 
[flink-benchmarks](https://github.com/apache/flink-benchmarks).
   
   Hi, @fredia, I wrote the following benchmark on my local Mac and ran the JMH 
test. `deleteRange` is almost 10 times faster than `Iterator`.
   ```
  @Benchmark
   public void mapClear(KeyValue keyValue) throws Exception {
   keyedStateBackend.setCurrentKey(keyValue.setUpKey);
   mapState.clear();
   }
   ```
   
   Performance test results using `Iterator`:
   ```
   Benchmark   (backendType)   Mode  Cnt Score Error   
Units
   MapStateBenchmark.mapClearROCKSDB  thrpt   3013.165 ±   2.088  
ops/ms
   ```
   Performance test results using `deleteRange`:
   ```
   Benchmark   (backendType)   Mode  Cnt Score Error   
Units
   MapStateBenchmark.mapClearROCKSDB  thrpt   30   121.860 ±  16.605  
ops/ms
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org