[GitHub] [flink] pnowojski commented on a change in pull request #9252: [FLINK-13051][runtime] Replace the non-selectable stream task with the input-selectable one

[GitBox]

pnowojski commented on a change in pull request #9252: [FLINK-13051][runtime] 
Replace the non-selectable stream task with the input-selectable one
URL: https://github.com/apache/flink/pull/9252#discussion_r312896295
 
 

 ##
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputSelectableProcessor.java
 ##
 @@ -280,11 +286,17 @@ else if (recordOrMark.isWatermark()) {
}
}
 
+   private void updateInputSelection() {
+   if (inputSelector != null) {
+   inputSelection = inputSelector.nextSelection();
+   }
 
 Review comment:
   maybe add an else branch with 
   
   ```
   else {
 inputSelection == InputSelection.ALL;
   }
   ```
   and re-use this in `prepareForProcessing`?
   
   I don't think that would add any measurable performance overhead, while 
would reduce code duplication by a bit? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #9252: [FLINK-13051][runtime] Replace the non-selectable stream task with the input-selectable one

[GitBox]

pnowojski commented on a change in pull request #9252: [FLINK-13051][runtime] 
Replace the non-selectable stream task with the input-selectable one
URL: https://github.com/apache/flink/pull/9252#discussion_r312896295
 
 

 ##
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputSelectableProcessor.java
 ##
 @@ -280,11 +286,17 @@ else if (recordOrMark.isWatermark()) {
}
}
 
+   private void updateInputSelection() {
+   if (inputSelector != null) {
+   inputSelection = inputSelector.nextSelection();
+   }
 
 Review comment:
   maybe add an else branch with 
   
   ```
   else {
 inputSelection == InputSelection.ALL;
   }
   ```
   and re-use this in `prepareForProcessing`?
   
   I don't think that would any measurable performance overhead, while would 
reduce code duplication by a bit? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #9252: [FLINK-13051][runtime] Replace the non-selectable stream task with the input-selectable one

[GitBox]

pnowojski commented on a change in pull request #9252: [FLINK-13051][runtime] 
Replace the non-selectable stream task with the input-selectable one
URL: https://github.com/apache/flink/pull/9252#discussion_r312903521
 
 

 ##
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTaskTest.java
 ##
 @@ -623,36 +597,19 @@ public void testHandlingEndOfInput() throws Exception {
testHarness.invoke();
testHarness.waitForTaskRunning();
 
-   TestBoundedTwoInputOperator headOperator = 
(TestBoundedTwoInputOperator) testHarness.getTask().headOperator;
-
 
 Review comment:
   Is this test simplification related to the rest of the commit? Was this test 
failing in the original form?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services