[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-654058889 > Thanks for the contribution. Why default value is 1? Why not keep Int.Max? @JingsongLi Thanks for your reply , The details link https://issues.apache.org/jira/browse/FLINK-17761 . FutureCompletingBlockingQueue is a LinkedBlockingQueue and it is created using the default constructor, so its depth is Integer.MAX_VALUE. So for a FetchTask to be blocked on a put(), it means that the queue is full so it has Integer.MAX_VALUE elements already . Integer.MAX_VALUE is too large . I changed the default value to 1 with @becketqin agree. At the same time, a construction method with capacity parameter is added. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-654045783 @JingsongLi @wuchong Can you review this PR for me? thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-651727239 @becketqin The problems have been solved, and the current error seems to have nothing to do with our changes . Looking forward to your reply , thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-651554556 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-651156382 > @pyscala Thanks for the patch. LGTM. Can we add a unit test for this? thanks @becketqin for your reply ,i will add a unit test for this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-641707884 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-641693599 Hi @becketqin ,appreciate for your time to review this PR,thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
