[GitHub] [flink] reswqa commented on a diff in pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

[via GitHub]

reswqa commented on code in PR #22207:
URL: https://github.com/apache/flink/pull/22207#discussion_r1160752449


##
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##
@@ -1945,8 +1938,4 @@ Map generateApplicationMasterEnv(
 Utils.setupYarnClassPath(this.yarnConfiguration, env);
 return env;
 }
-
-private String getDisplayMemory(long memoryMB) {

Review Comment:
   It seems that some test case related to this is failed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] reswqa commented on a diff in pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

[via GitHub]

reswqa commented on code in PR #22207:
URL: https://github.com/apache/flink/pull/22207#discussion_r1160743167


##
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##
@@ -1945,8 +1938,4 @@ Map generateApplicationMasterEnv(
 Utils.setupYarnClassPath(this.yarnConfiguration, env);
 return env;
 }
-
-private String getDisplayMemory(long memoryMB) {

Review Comment:
   Why remove this method? Is it because of even if we use a long value, 
converting to byte here will still overflow? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] reswqa commented on a diff in pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

[via GitHub]

reswqa commented on code in PR #22207:
URL: https://github.com/apache/flink/pull/22207#discussion_r1160743167


##
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##
@@ -1945,8 +1938,4 @@ Map generateApplicationMasterEnv(
 Utils.setupYarnClassPath(this.yarnConfiguration, env);
 return env;
 }
-
-private String getDisplayMemory(long memoryMB) {

Review Comment:
   Even if we use a long value, converting to byte here will still overflow, 
right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org