rudikershaw opened a new pull request, #19721:
URL: https://github.com/apache/flink/pull/19721
## What is the purpose of the change
When adding jars to the `/lib` directory any extra jar files that match the
pattern `flink-dist*.jar` provoke an error when trying to use `BashJavaUtils`
to get JVM parameters and dynamic configurations in `config.sh`. Although
niche, this can be difficult to debug because there is no error message to
describe the issue.
We already print a useful error message if no `flink-dist*.jar` can be found
at all. This pull request adds another error message when more than one
`flink-dist*.jar` is found at this point.
## Brief change log
- Fix minor typo in README.md
- Add error message for when more than one file matching `flink-dist*.jar`
exists in `/lib`.
- Actioned a few minor shellcheck issues on the lines changed.
## Verifying this change
This change can be verified as follows:
- `./mvnw clean install -DskipTests -Dfast`
- `cp flink-dist-scala/target/flink-dist-scala_2.12-1.16-SNAPSHOT.jar
build-target/lib/`
- `build-target/bin/start-cluster.sh`
- You should see the error message "[ERROR] Multiple flink-dist*.jar found
in /path/to/lib. Please resolve."
- `rm build-target/lib/flink-dist-scala_2.12-1.16-SNAPSHOT.jar`
- `build-target/bin/start-cluster.sh`
- The cluster should start successfully.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): No
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: No
- The serializers: No
- The runtime per-record code paths (performance sensitive): No
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: No
- The S3 file system connector: No
## Documentation
- Does this pull request introduce a new feature? No
- If yes, how is the feature documented? Not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
