[GitHub] [flink] slfan1989 commented on pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

2023-04-08 Thread via GitHub 


slfan1989 commented on PR #22207:
URL: https://github.com/apache/flink/pull/22207#issuecomment-1501007098

   > Thanks @slfan1989 for the update, would you mind squashing all to only one 
commit with the message like:
   
   @reswqa Thank you for your help to review the code! I will rebase and submit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] slfan1989 commented on pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

2023-04-07 Thread via GitHub 


slfan1989 commented on PR #22207:
URL: https://github.com/apache/flink/pull/22207#issuecomment-1500183076

   @reswqa Can you help review this PR again? Thank you very much! I explained 
the reason for possible negative numbers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] slfan1989 commented on pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

2023-03-23 Thread via GitHub 


slfan1989 commented on PR #22207:
URL: https://github.com/apache/flink/pull/22207#issuecomment-1482249297

   > Thanks @slfan1989 for creating this.
   > 
   > How did you manually verify this issue, could you describe it in detail?
   > 
   > By the way, would you mind resolving conflict in `YarnClusterDescriptor`?
   
   @reswqa Thank you very much for your suggestion, I will modify the 
information as soon as possible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org