[GitHub] [flink] slinkydeveloper commented on a change in pull request #17656: [FLINK-24741]Deprecate FileRecordFormat

2021-11-03 Thread GitBox 


slinkydeveloper commented on a change in pull request #17656:
URL: https://github.com/apache/flink/pull/17656#discussion_r742125995



##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/impl/FileRecordFormatAdapter.java
##
@@ -37,7 +37,12 @@
 import static org.apache.flink.util.Preconditions.checkArgument;
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
-/** The FormatReaderAdapter turns a {@link FileRecordFormat} into a {@link 
BulkFormat}. */
+/**
+ * This interface is Deprecated, use {@link StreamFormatAdapter} instead.

Review comment:
   Same

##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/reader/FileRecordFormat.java
##
@@ -34,7 +34,14 @@
 import java.io.Serializable;
 
 /**
- * A reader format that reads individual records from a file.
+ * This interface is Deprecated, use {@link StreamFormat} instead. The main 
motivation for removing

Review comment:
   Same

##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/FileSource.java
##
@@ -181,12 +178,15 @@ private FileSource(
 }
 
 /**
- * Builds a new {@code FileSource} using a {@link FileRecordFormat} to 
read record-by-record
+ * This method is Deprecated, use {@link 
#forRecordStreamFormat(StreamFormat, Path...)} instead.

Review comment:
   Please use the javadoc `@deprecated` tag




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17656: [FLINK-24741]Deprecate FileRecordFormat

2021-11-03 Thread GitBox 


slinkydeveloper commented on a change in pull request #17656:
URL: https://github.com/apache/flink/pull/17656#discussion_r742125995



##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/impl/FileRecordFormatAdapter.java
##
@@ -37,7 +37,12 @@
 import static org.apache.flink.util.Preconditions.checkArgument;
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
-/** The FormatReaderAdapter turns a {@link FileRecordFormat} into a {@link 
BulkFormat}. */
+/**
+ * This interface is Deprecated, use {@link StreamFormatAdapter} instead.

Review comment:
   Same

##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/reader/FileRecordFormat.java
##
@@ -34,7 +34,14 @@
 import java.io.Serializable;
 
 /**
- * A reader format that reads individual records from a file.
+ * This interface is Deprecated, use {@link StreamFormat} instead. The main 
motivation for removing

Review comment:
   Same

##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/FileSource.java
##
@@ -181,12 +178,15 @@ private FileSource(
 }
 
 /**
- * Builds a new {@code FileSource} using a {@link FileRecordFormat} to 
read record-by-record
+ * This method is Deprecated, use {@link 
#forRecordStreamFormat(StreamFormat, Path...)} instead.

Review comment:
   Please use the javadoc `@deprecated` tag

##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/impl/FileRecordFormatAdapter.java
##
@@ -37,7 +37,12 @@
 import static org.apache.flink.util.Preconditions.checkArgument;
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
-/** The FormatReaderAdapter turns a {@link FileRecordFormat} into a {@link 
BulkFormat}. */
+/**
+ * This interface is Deprecated, use {@link StreamFormatAdapter} instead.

Review comment:
   Same

##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/reader/FileRecordFormat.java
##
@@ -34,7 +34,14 @@
 import java.io.Serializable;
 
 /**
- * A reader format that reads individual records from a file.
+ * This interface is Deprecated, use {@link StreamFormat} instead. The main 
motivation for removing

Review comment:
   Same

##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/FileSource.java
##
@@ -181,12 +178,15 @@ private FileSource(
 }
 
 /**
- * Builds a new {@code FileSource} using a {@link FileRecordFormat} to 
read record-by-record
+ * This method is Deprecated, use {@link 
#forRecordStreamFormat(StreamFormat, Path...)} instead.

Review comment:
   Please use the javadoc `@deprecated` tag




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17656: [FLINK-24741]Deprecate FileRecordFormat

2021-11-03 Thread GitBox 


slinkydeveloper commented on a change in pull request #17656:
URL: https://github.com/apache/flink/pull/17656#discussion_r742125995



##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/impl/FileRecordFormatAdapter.java
##
@@ -37,7 +37,12 @@
 import static org.apache.flink.util.Preconditions.checkArgument;
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
-/** The FormatReaderAdapter turns a {@link FileRecordFormat} into a {@link 
BulkFormat}. */
+/**
+ * This interface is Deprecated, use {@link StreamFormatAdapter} instead.

Review comment:
   Same

##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/reader/FileRecordFormat.java
##
@@ -34,7 +34,14 @@
 import java.io.Serializable;
 
 /**
- * A reader format that reads individual records from a file.
+ * This interface is Deprecated, use {@link StreamFormat} instead. The main 
motivation for removing

Review comment:
   Same

##
File path: 
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/FileSource.java
##
@@ -181,12 +178,15 @@ private FileSource(
 }
 
 /**
- * Builds a new {@code FileSource} using a {@link FileRecordFormat} to 
read record-by-record
+ * This method is Deprecated, use {@link 
#forRecordStreamFormat(StreamFormat, Path...)} instead.

Review comment:
   Please use the javadoc `@deprecated` tag




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org